fix: Add WithMessageBus and TaskPool schedulers with RxAppBuilder#4282
Merged
ChrisPulman merged 2 commits intomainfrom Jan 31, 2026
Merged
fix: Add WithMessageBus and TaskPool schedulers with RxAppBuilder#4282ChrisPulman merged 2 commits intomainfrom
ChrisPulman merged 2 commits intomainfrom
Conversation
Introduce a unified WithMessageBus API (WithMessageBus(), WithMessageBus(IMessageBus), WithMessageBus(Action<IMessageBus>)) and implement message-bus registration in ReactiveUIBuilder. Add RegisterConstantViewModel<TViewModel>() to register constant VM instances. Configure TaskPoolScheduler.Default via WithTaskPoolScheduler in multiple platform builder extensions (AndroidX, Blazor, Maui, WinUI, WinForms, WPF) instead of platform registration files. Remove direct RxSchedulers assignments from several platform Registrations to centralize scheduler setup. Update mixins, tests, examples and project files to use the new APIs and clean up minor issues (usings, default expressions, project metadata, and API approval baselines).
Replace occurrences of Services.RoomEventMessage with the unqualified RoomEventMessage in LobbyViewModel. Updates message listening, sync request/response creation, ApplyRoomEvent signature, and broadcast events for room create/delete to use the shorter type name.
glennawatson
changed the title
glennawatson
approved these changes
Jan 31, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4282 +/- ##
==========================================
- Coverage 89.78% 89.65% -0.14%
==========================================
Files 251 251
Lines 9559 9574 +15
Branches 1456 1454 -2
==========================================
+ Hits 8583 8584 +1
- Misses 741 756 +15
+ Partials 235 234 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Update
What is the current behavior?
TaskPoolScheduler is null when using platform builder extensions i.e. WithWpf()
Schedulers were set in Registrations
What is the new behavior?
Introduce a unified WithMessageBus API (WithMessageBus(), WithMessageBus(IMessageBus), WithMessageBus(Action)) and implement message-bus registration in ReactiveUIBuilder. Add RegisterConstantViewModel() to register constant VM instances. Configure TaskPoolScheduler.Default via WithTaskPoolScheduler in multiple platform builder extensions (AndroidX, Blazor, Maui, WinUI, WinForms, WPF) instead of platform registration files. Remove direct RxSchedulers assignments from several platform Registrations to centralize scheduler setup. Update mixins, tests, examples and project files to use the new APIs and clean up minor issues (usings, default expressions, project metadata, and API approval baselines).
What might this PR break?
currently beta edition, ConfigureMessageBus is now WithMessageBus in all cases
Please check if the PR fulfills these requirements
Other information: